Merged
Conversation
Just so there's a different commit that shows the changes due to import/export. Basically done by XML formatting in notepad++ and replacing tabs with spaces.
My eclipse version: 2024-12. Only removed a date string from the .importorder. Might revert that anyway, as the way it was made a bit more sense for us?
I don't know where to import them anyway...
Got warning about encoding when building locally. And for some reason I had the URL change locally, might as well add it now...
Hilbrand
approved these changes
Jan 31, 2025
Member
Hilbrand
left a comment
Hilbrand
left a comment
There was a problem hiding this comment.
LGTM
- The c formatting requires C support being added. It was intended for OpenCL, but I'm not sure if it's used. We probably won't miss it.
- The
eclipse_java_templatescan be imported inJava->Editor->Templates. It will add option to code complete the license. Effectively when you typecopyright(or part of it and press space) it will replace it with the copyright statement. I don't think we'll miss it as the copyright is also set when new files are created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, it's a mess. But that's mainly because our files weren't formatted, and also apparantly quite old?
Main reason to do this, is that our spotless configuration uses the eclipse format file, and since it didn't contain new information it wanted to format
recordclasses a bit weird.Unsure about the eclipse.importorder, this is the way eclipse exports it, but don't mind our own ordering-with-comments.
Did delete 2 files, as I don't know where to import (and then export) them, so guess these are not used anyway?